Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pagination query param configurable #256

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Make pagination query param configurable #256

merged 1 commit into from
Apr 19, 2024

Conversation

hramezani
Copy link
Member

Fixes #203

sydney-runkle
sydney-runkle requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - could you please add one test to showcase how this new functionality works?

@sydney-runkle
Copy link
Member

Working locally, no simple way to test :)

@sydney-runkle sydney-runkle merged commit bc8ac94 into main Apr 19, 2024
14 checks passed
@sydney-runkle sydney-runkle deleted the pagination-query-param branch April 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination needs to have the query param it sets configurable
2 participants
@hramezani @sydney-runkle